Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spike] Conventional Provider Partnerships in Publish #4730

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

[Spike] Conventional Provider Partnerships in Publish #4730

wants to merge 10 commits into from

Conversation

inulty-dfe
Copy link
Contributor

@inulty-dfe inulty-dfe commented Dec 2, 2024 •
edited
Loading

Context

This PR demonstrates the mechanics of the formalised Provider partnership association.

Things to consider.

  1. The association is done through the provider.id for both sides of the join. The enrichments stores the provider code.
  2. With the provider code we would need to reference the recruitment cycle (or assume the same recruitment cycle as the other side of the association)
  3. Validations added
    • Accredited provider must exist
    • Accredited provider must be an accredited provider
    • Training provider must exist
    • Training provider must not be an accredited provider
    • Two partnerships may not be created between the same providers

Changes proposed in this pull request

Guidance to review

@inulty-dfe
Add migration to create ProviderPartnership
17a8d2b 
  The ProviderPartnership will join a Training partner to an Accredited
  provider

  It's not clear yet if we should use the Accredited provider code or id
@inulty-dfe
Add provider_partnership to dfe-analytics
7b3d09f
@inulty-dfe
Migrate provider_partnership table
bac8c4e
@inulty-dfe
Add accredited_provider factory
388a51e 
  Easier to write create(:accredited_provider)
  than create(:provider, :accredited_provider)
@inulty-dfe
Add ProviderPartnership model
a767dff 
  - validate presence of training and accredited partners
  - validate that each are the correct "type"
@inulty-dfe
Add ProviderPartnership factory
d32dac8
@inulty-dfe
Add accredited and training partnership Provider association
6beb5fa
@inulty-dfe
Move validation messages to locales en.yml
23e8042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
spike
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@inulty-dfe