Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional clawback details on show page #1240

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dp-daly
Copy link
Contributor

@dp-daly dp-daly commented Dec 13, 2024

Context

We are making progressive enhancements to the support console to assist in the processing of Claims.

Changes proposed in this pull request

  • Add the Clawback details to the clawbacks show page (an initial show page was added in dpd/request-clawback-wizard)
  • Use change links on 'number of hours' and 'reason for clawback' which link to the edit request clawback wizard. This section should only be visible if a clawback has been requested.
  • If the clawback is in progress the Clawback details should be visible, but the change links should not be available.

Guidance to review

  • Navigate to the show page of claims with all three clawback statuses (sampling_not_approved, clawback_requested, and clawback_in_progress.
  • Check them against the logic outlined above.
  • Note that the values for clawback hours and reason are not yet in place. Changes to the Claims table have been postponed until a further design iteration has been approved and handed over.

Link to Trello card

https://trello.com/c/eyaECIcP/999-clawbacks-add-clawback-show-page

@dp-daly dp-daly requested a review from a team as a code owner December 13, 2024 17:54
@dp-daly dp-daly force-pushed the dpd/clawback-details-on-show-page branch from 255bc5c to 93b6159 Compare December 13, 2024 18:07
@dp-daly dp-daly self-assigned this Dec 13, 2024
@dp-daly dp-daly force-pushed the dpd/request-clawback-wizard branch from 2022cfa to 2c7c639 Compare December 17, 2024 12:09
@dp-daly dp-daly requested a review from a team as a code owner December 17, 2024 12:09
@dp-daly dp-daly force-pushed the dpd/request-clawback-wizard branch from 2c7c639 to e792100 Compare December 17, 2024 12:18
@dp-daly dp-daly force-pushed the dpd/clawback-details-on-show-page branch from 93b6159 to 62dfe4d Compare December 17, 2024 12:33
@dp-daly dp-daly force-pushed the dpd/request-clawback-wizard branch from e792100 to e090085 Compare December 18, 2024 15:16
Base automatically changed from dpd/request-clawback-wizard to main December 19, 2024 11:54
@dp-daly dp-daly force-pushed the dpd/clawback-details-on-show-page branch from 1414289 to 1e9a6c7 Compare December 19, 2024 14:16
@dp-daly dp-daly force-pushed the dpd/clawback-details-on-show-page branch from 1e9a6c7 to 92a0e41 Compare December 24, 2024 09:38
@dp-daly dp-daly added the deploy A Review App will be created for PRs with this label label Dec 24, 2024
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants