Log session answers to rollbar #3478
Conversation
rjlynch
force-pushed
the
CAPT-1861/log_session_answers
branch
from
98870de to
c642bc0
Compare
rjlynch
force-pushed
the
CAPT-1861/log_session_answers
branch
from
c642bc0 to
4e32654
Compare
| end | ||
| end | ||
|
|
||
| def attributes_with_pii_redacted |
There was a problem hiding this comment.
can we add some basic coverage for this method?
There was a problem hiding this comment.
There is already some config here https://github.com/DFE-Digital/claim-additional-payments-for-teaching/blob/master/app/models/claim.rb#L20 from when the Claim object was built during the journey. It might be that this is now redundant or could be considered as part of this change. I think the list of filtered attributes should be managed in one place.
Some of the errors in rollbar are tricky to debug as we don't know what answers the claimant provided. This commit adds a mechanism for flagging attributes as PII and updates the ClaimsController to include the non pii attributes in the Rollbar scope such that they are available in Rollbar.
We want to avoid future devs over looking flagging new attributes as pii. This commit makes the pii indicator a required option when adding a new attribute.
rjlynch
force-pushed
the
CAPT-1861/log_session_answers
branch
from
4e32654 to
e97aae4
Compare
rjlynch
force-pushed
the
CAPT-1861/log_session_answers
branch
from
e97aae4 to
45b8e33
Compare
Claim filter params is no longer needed as it's been superseded by the `pii` option on the SessionAttribute answers. As the wizards are backed by the session answers class and don't directly write attributes to the claim we've decided to keep the sensitive attribute flagging as close to the attribute definition as possible, this removed the need for developers to remember to update this list on the claim when writing adding a new attribute that might not be written to the claim (it may be written to an eligibility).
rjlynch
force-pushed
the
CAPT-1861/log_session_answers
branch
from
45b8e33 to
707fe04
Compare
@slorek I've opted to remove the |
Some of the errors in rollbar are tricky to debug as we don't know what
answers the claimant provided. This commit adds a mechanism for flagging
attributes as PII and updates the ClaimsController to include the non
pii attributes in the Rollbar scope such that they are available in
Rollbar.
Here are two errors in rollbar showing the additional params sent over https://app.rollbar.com/a/dfe-digital/fix/item/dfe-claims/1530#occurrences
We couldn't reuse the config/analytics_blocklist.yml list for scrubbing pi as journey sessions store all answers in the
answersdb column and we just block the whole column. I think tacking onpii: trueto the attribute definition isn't too much overhead and may end up being useful in other contexts.