Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.4 #11

Merged
merged 3 commits into from
Nov 20, 2024
Merged

v0.2.4 #11

merged 3 commits into from
Nov 20, 2024

Conversation

D4Vinci
Copy link
Owner

@D4Vinci D4Vinci commented Nov 20, 2024

What's changed

Bugs Squashed

  • Fixed a bug when retrieving response bytes after using the network_idle argument in both the StealthyFetcher and PlayWrightFetcher classes.
    That was causing the following error message:
Response.body: Protocol error (Network.getResponseBody): No resource with given identifier found
  • The PlayWright API sometimes returns empty status text with responses, so now Scrapling will calculate it manually if that happens. This affects both the StealthyFetcher and PlayWrightFetcher classes.

Note

A friendly reminder that maintaining and improving Scrapling takes a lot of time and effort which I have been happily doing for months even though it's becoming harder. So, if you like Scrapling and want it to keep improving, you can help by supporting me through the Sponsor button.

…`network_idle` is used

PlayWright doesn't provide a way to get the response in bytes after all wait ends like `page.content()` so that's more efficient to do anyway
@D4Vinci D4Vinci merged commit e9b0102 into main Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant