Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 use mime-type application/ld+json instead of text/plain #29

Merged
merged 2 commits into from
Apr 7, 2024
Merged

🐛 use mime-type application/ld+json instead of text/plain #29

merged 2 commits into from
Apr 7, 2024

Conversation

thunfisch987
Copy link
Contributor

closes #28

@thunfisch987
Copy link
Contributor Author

thunfisch987 commented Apr 6, 2024

i did not manage to build it on my system, is there a way to do that?
(i don't have much experience with minecraft modding)
i want to try including an option for https via a config option but i would need to build it on my system for testing

i got it working (only thing missing was my github username and token)

@thunfisch987 thunfisch987 changed the title 🐛 :use mime-type application/ld+json instead of text/plain 🐛 use mime-type application/ld+json instead of text/plain Apr 6, 2024
@thunfisch987
Copy link
Contributor Author

Since i got it to build on my machine i tested it and it works!

@rubensworks rubensworks changed the base branch from master-1.20 to master-1.19-lts April 7, 2024 08:47
@rubensworks rubensworks changed the base branch from master-1.19-lts to master-1.20 April 7, 2024 08:47
@rubensworks rubensworks merged commit 4c6cfaa into CyclopsMC:master-1.20 Apr 7, 2024
1 of 2 checks passed
@rubensworks
Copy link
Member

Thanks @thunfisch987!
Will prepare a new release in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output cannot be automatically parsed as json/jsonld
2 participants