Clear facade recipes #1445
Closed
Clear facade recipes #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: * Fix inputs of JEI recipes not being recognized Closes CyclopsMC#1312
Fixes: * Fix Jade integration not working, Closes CyclopsMC#1438
Co-authored-by: Crowdin Bot <[email protected]>
rubensworks
requested changes
Dec 23, 2024
|
I could modify the 2 existing recipe types to directly call the calculator method, but the reason I did it with an additional recipe type is to make it clear in the JSON recipe files that it's a special type. If you think that just putting it in the special folder twice won't cause too much confusion, I'll go ahead and modify the 2 existing classes to directly call the calculator method. |
|
Sure, modifying the existing recipe type is fine. It would become a bit similar to the crafting recipe type, so we can probably even use the same method name as there. |
kirjorjos
force-pushed
the
clear-facade-recipes
branch
from
e5cfb01 to
1344049
Compare
|
I'm closing this PR to open a new one on a new branch to both keep the commit history cleaner and help me make sure I don't forget to delete any unrequired code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1424 by adding a normal crafting recipe for lossy clearing and a recipe in both squeezers for non-lossy clearing