fix: use the non-deprecated version of metadata/tools for 1.5+ #1343
Conversation
Signed-off-by: Jeremy Long <[email protected]>
| @@ -332,10 +337,15 @@ export class CycloneDxWebpackPlugin { | |||
| ? undefined | |||
| : new Date() | |||
|
|
|||
| for (const tool of this.#makeTools(cdxToolBuilder, logger.getChildLogger('ToolMaker'))) { | |||
| bom.metadata.tools.add(tool) | |||
| if (this.specVersion >= CDX.Spec.Version.v1dot5) { | |||
There was a problem hiding this comment.
no need for code branching.
the library knows how to transform a component to atool, if required.
see existing art:
|
the changes in this PR are considered a breaking change. |
This comment was marked as outdated.
This comment was marked as outdated.
|
thank you for the contribution, @jeremylong It looks like your changes duplicate #1331. |
| "type": "library", | ||
| "name": "cyclonedx-library", | ||
| "group": "@cyclonedx", | ||
| "version": "7.0.0", |
There was a problem hiding this comment.
this should be "version": "libVersion-testing",
| "type": "library", | ||
| "name": "webpack-plugin", | ||
| "group": "@cyclonedx", | ||
| "version": "3.15.1", |
There was a problem hiding this comment.
this should be "version": "thisVersion-testing",
|
This PR is being closed as a duplicate. I didn't see you had already started implementing this. Any idea what your timeline is for the next release with your PRs? |
|
next release is planned for January 2025. |
fixes #1330
closes #1331