-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: artificial package deduplication #309
Draft
jkowalleck
wants to merge
2
commits into
main
Choose a base branch
from
artificial-deduplication
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkowalleck
force-pushed
the
artificial-deduplication
branch
from
November 11, 2022 18:13
1c17b91
to
06858ac
Compare
jkowalleck
force-pushed
the
artificial-deduplication
branch
2 times, most recently
from
November 12, 2022 08:51
ba005b6
to
29e7513
Compare
jkowalleck
commented
Nov 12, 2022
@@ -0,0 +1,3 @@ | |||
# Component De-duplication | |||
|
|||
TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
@@ -251,6 +254,9 @@ export class BomBuilder { | |||
bom.components.add(component) | |||
} | |||
} | |||
if (this.deduplicateComponents) { | |||
// TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
jkowalleck
force-pushed
the
artificial-deduplication
branch
2 times, most recently
from
November 12, 2022 15:00
6667a4f
to
da9372f
Compare
Signed-off-by: Jan Kowalleck <[email protected]>
jkowalleck
force-pushed
the
artificial-deduplication
branch
from
November 12, 2022 15:05
da9372f
to
c624209
Compare
Signed-off-by: Jan Kowalleck <[email protected]>
jkowalleck
force-pushed
the
artificial-deduplication
branch
from
November 12, 2022 15:05
c624209
to
2983707
Compare
jkowalleck
commented
Nov 12, 2022
@@ -4,9 +4,13 @@ All notable changes to this project will be documented in this file. | |||
|
|||
## unreleased | |||
|
|||
* Added | |||
* new CLI option `--deduplicate-components` ... write something ([#306] via [#309]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #306
based on the outcome of #304