Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: artificial package deduplication #309

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Nov 11, 2022

fixes #306

based on the outcome of #304

  • implement the option
  • implement the solution
  • implement the tests
  • add demo results

@jkowalleck jkowalleck added the enhancement New feature or request label Nov 11, 2022
@jkowalleck jkowalleck force-pushed the artificial-deduplication branch from 1c17b91 to 06858ac Compare November 11, 2022 18:13
@jkowalleck jkowalleck force-pushed the artificial-deduplication branch 2 times, most recently from ba005b6 to 29e7513 Compare November 12, 2022 08:51
@@ -0,0 +1,3 @@
# Component De-duplication

TODO
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@@ -251,6 +254,9 @@ export class BomBuilder {
bom.components.add(component)
}
}
if (this.deduplicateComponents) {
// TODO
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@jkowalleck jkowalleck force-pushed the artificial-deduplication branch 2 times, most recently from 6667a4f to da9372f Compare November 12, 2022 15:00
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck force-pushed the artificial-deduplication branch from da9372f to c624209 Compare November 12, 2022 15:05
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck force-pushed the artificial-deduplication branch from c624209 to 2983707 Compare November 12, 2022 15:05
@@ -4,9 +4,13 @@ All notable changes to this project will be documented in this file.

## unreleased

* Added
* new CLI option `--deduplicate-components` ... write something ([#306] via [#309])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEAT: component de-duplication
1 participant