Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: copy/past mime-helpers #1246

Merged
merged 4 commits into from
Dec 18, 2024
Merged

refactor: copy/past mime-helpers #1246

merged 4 commits into from
Dec 18, 2024

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Dec 17, 2024

followup of #1243

make implementation a copy-past of existing art: https://github.com/CycloneDX/cyclonedx-node-yarn/blob/main/src/_helpers.ts

this should make it easier for CycloneDX/cyclonedx-javascript-library#1162

@jkowalleck jkowalleck requested a review from a team as a code owner December 17, 2024 16:19
@jkowalleck jkowalleck force-pushed the refactor/cp_mime_helpers branch from 119c71d to 2a2f96a Compare December 17, 2024 16:27
@jkowalleck jkowalleck marked this pull request as draft December 17, 2024 17:12
@jkowalleck jkowalleck force-pushed the refactor/cp_mime_helpers branch from 2a2f96a to b77c47c Compare December 17, 2024 17:14
Copy link

codacy-production bot commented Dec 17, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-1.92% 80.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b067232) 1320 1101 83.41%
Head commit (f175f57) 1329 (+9) 1083 (-18) 81.49% (-1.92%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1246) 10 8 80.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkowalleck jkowalleck force-pushed the refactor/cp_mime_helpers branch from b77c47c to b0224e1 Compare December 17, 2024 17:50
make implementation a copy-past of exisitng art: <https://github.com/CycloneDX/cyclonedx-node-yarn/blob/main/src/_helpers.ts>

Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck force-pushed the refactor/cp_mime_helpers branch from b0224e1 to de32197 Compare December 18, 2024 18:12
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck force-pushed the refactor/cp_mime_helpers branch from 5caa19a to 3110d37 Compare December 18, 2024 20:46
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck marked this pull request as ready for review December 18, 2024 21:36
@jkowalleck jkowalleck merged commit c0c3f7d into main Dec 18, 2024
33 of 34 checks passed
@jkowalleck jkowalleck deleted the refactor/cp_mime_helpers branch December 18, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant