Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnsupportedOperationException when modifying an existing metadata.tools list #574

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

mr-zepol
Copy link
Contributor

This PR fixes the issue #571

Copy link

codacy-production bot commented Dec 14, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+74.67% 84.21%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (66fcb64) 0 0 0.00%
Head commit (51dc9d2) 6426 (+6426) 4798 (+4798) 74.67% (+74.67%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#574) 38 32 84.21%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mr-zepol Unfortunately there's now a merge conflict here. Happy to merge once that is resolved!

@nscuro nscuro added the bug Something isn't working label Dec 21, 2024
@mr-zepol
Copy link
Contributor Author

@mr-zepol Unfortunately there's now a merge conflict here. Happy to merge once that is resolved!

Done

@nscuro nscuro changed the title Fix 571 Fix UnsupportedOperationException when modifying an existing metadata.tools list Dec 21, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mr-zepol!

@nscuro nscuro merged commit 26bd89a into master Dec 21, 2024
10 checks passed
@nscuro nscuro deleted the issue_571 branch December 21, 2024 15:17
@nscuro nscuro added this to the 10.0.1 milestone Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants