Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle swipe gestures interference #4224

Closed
wants to merge 2 commits into from

Conversation

Jadessu
Copy link
Contributor

@Jadessu Jadessu commented Oct 19, 2024

Describe your changes

prevent swipe gestures from unintentionally affecting the background content when interacting with modals or charts on mobile devices.
Content:

Added logic to disable swipe gestures when a bottom sheet is open, ensuring that background content is not affected by swiping actions.
Updated the behavior for chart interactions to prevent swipe gestures from being triggered when users are interacting with a chart
Ensured that swipe gestures only function in areas outside of active modals or charts
Closes #0000

Checklist before requesting a review

  • Is this PR ready for merge? (Please convert to a draft PR otherwise)
  • I have performed a self-review of my code.
  • Did I request feedback from a team member prior to the merge?
  • Does my code following the style guide at docs/CODING-STYLE.md?

Instructions for Reviewers

Functionalities or workflows that should specifically be tested.

Environmental conditions that may result in expected but differential behavior.

If relevant, list additional work to complete pre-merge (delete logging, code abstraction, etc)

Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for dev-ambi ready!

Name Link
🔨 Latest commit 2182fb2
🔍 Latest deploy log https://app.netlify.com/sites/dev-ambi/deploys/6713e2bf4feabc000892366d
😎 Deploy Preview https://deploy-preview-4224--dev-ambi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for futa-finance ready!

Name Link
🔨 Latest commit 2182fb2
🔍 Latest deploy log https://app.netlify.com/sites/futa-finance/deploys/6713e2bfda3be0000872a6e2
😎 Deploy Preview https://deploy-preview-4224--futa-finance.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benwolski benwolski closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants