Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Challenge]: feat: new payment flow prototype #365

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

mariaaenc
Copy link

  • You have read the CONTRIBUTING.md - File not exists
  • For Terraform changes, you have read the Terraform Naming Conventions - Does not apply
  • For Terraform changes, you have already executed the Terraform plan on this branch - Does not apply
  • The changes inside this pull request are organization-agnostic

Why?

Challenge for Backend Software Engineer (individual-assignment)

What?

  • Organize classes into specific files for their use and the files for this challenge into a new folder called typescript.
  • Install jest, ts-jest and @types/jest libraries for testing and implement unit tests.
  • Install prettier library for code formatting.
  • Create a function to execute processes after purchase according to the rules specified in the challenge.

Jira link:

How:

  • Since the process is different for each type of product, a Map was implemented that is used to redirect to the specific class that contains the processes for each product.

Comments:

Enter the correct folder: cd backend/individual-assignment/typescript
Install the libraries with the command: npm install
Script to run tests: npm run test
Script to format code: npm run format

Coverage:

Captura de Tela 2024-08-11 às 12 04 46

@robo-bankfacil-app robo-bankfacil-app bot added the creditas:size:xl Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 11, 2024
@mariaaenc mariaaenc changed the title [Challenge]: New payment flow prototype [Challenge]: feat: new payment flow prototype Aug 11, 2024
@robo-bankfacil-app robo-bankfacil-app bot added the creditas:kind:feature Implementação de novas funcionalidades ou melhorias label Aug 11, 2024
Copy link

Pull Request Analyzer - Failed

Hi @mariaaenc!

🚀 Analysis

✔️ Pull Request Description Approved
✔️ Pull Request Title Approved

⁉️ Actions Items

☑️ CheckList

Existem itens no checklist do pull request que não obrigatórios, por favor leia eles com atenção e conclua antes de avançar com o merge.

  • ❗ You have read the CONTRIBUTING.md - File not exists
  • ❗ For Terraform changes, you have read the Terraform Naming Conventions - Does not apply
  • ❗ For Terraform changes, you have already executed the Terraform plan on this branch - Does not apply

🔑 CODEOWNERS

Não foi encontrado arquivo CODEOWNERS ou .github/CODEOWNERS no repositorio!


🏷️ Category

Não foi encontrado a label de categoria do Pull Request, selecione somente uma das labels abaixo:

  • creditas:task:planned: Utilizada para sinalizar PR que tem origem itens planejados
  • creditas:task:unplanned: Utilizado para sinalizar PR expontaneas que não estão relacionadas a atividades no board do jira
  • creditas:task:emergency: Utilizado para sinalizar que é uma tarefa emergencial, como por exemplo um BOPE ou um Revert

ℹ️ Mais informações

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
creditas:kind:feature Implementação de novas funcionalidades ou melhorias creditas:size:xl Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant