Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tests for messages execution order #2052

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kulikthebird
Copy link
Contributor

No description provided.

@kulikthebird kulikthebird force-pushed the tkulik/replies_tests branch 4 times, most recently from 529e1b2 to efafeae Compare December 9, 2024 09:34
@kulikthebird kulikthebird marked this pull request as ready for review December 9, 2024 09:36
@kulikthebird kulikthebird self-assigned this Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.89%. Comparing base (0ef57e7) to head (136af85).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2052      +/-   ##
==========================================
+ Coverage   42.85%   42.89%   +0.03%     
==========================================
  Files          85       85              
  Lines       11587    11587              
==========================================
+ Hits         4966     4970       +4     
+ Misses       6180     6178       -2     
+ Partials      441      439       -2     

see 1 file with indirect coverage changes

@kulikthebird kulikthebird force-pushed the tkulik/replies_tests branch 3 times, most recently from 05ce134 to f41a696 Compare December 10, 2024 09:00
@kulikthebird
Copy link
Contributor Author

Related PR with implementation of the replier contract: CosmWasm/cosmwasm#2306

Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! The test cases all look correct to me.
If it's easily possible to make this a table test, that would be great.

},
}

func TestMultipleReplies(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in Go it's more idiomatic to use table tests in a case like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants