-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add tests for messages execution order #2052
base: main
Are you sure you want to change the base?
Conversation
529e1b2
to
efafeae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2052 +/- ##
==========================================
+ Coverage 42.85% 42.89% +0.03%
==========================================
Files 85 85
Lines 11587 11587
==========================================
+ Hits 4966 4970 +4
+ Misses 6180 6178 -2
+ Partials 441 439 -2 |
05ce134
to
f41a696
Compare
Related PR with implementation of the replier contract: CosmWasm/cosmwasm#2306 |
e82e21c
to
6113b1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice! The test cases all look correct to me.
If it's easily possible to make this a table test, that would be great.
x/wasm/keeper/keeper_test.go
Outdated
}, | ||
} | ||
|
||
func TestMultipleReplies(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in Go it's more idiomatic to use table tests in a case like this.
136af85
to
8bb517c
Compare
bb742b1
to
a37fd43
Compare
No description provided.