Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only set unset additionalProperties fields to false #2310

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Only set unset additionalProperties fields to false #2310

wants to merge 2 commits into from

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Dec 12, 2024

Closes #2309

@aumetra aumetra marked this pull request as ready for review December 20, 2024 23:05
@aumetra
Copy link
Member Author

aumetra commented Dec 20, 2024

@snoyberg apologies for the delay. It would be great if you could run your codegen against this patch and see if the schemas look good. If they do, we can merge this.

@snoyberg
Copy link
Contributor

Thank you @aumetra! I can confirm that with this change, we end up with the correct generated schema files. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

@chipshort chipshort Awaiting requested review from chipshort

@kulikthebird kulikthebird Awaiting requested review from kulikthebird

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schema_for! on HashMap and BTreeMap no longer generates field information for values
2 participants
@aumetra @snoyberg