This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Introduce the concept of 'entity' in decoded TX #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An entity groups related ERC standards, providing an abstraction on what kind of concept they refer to. In this way, different token interfaces can co-exist while making it easy to filter for all token transactions in a block, regardless of the underlying ERC interface (e.g. ERC20, ERC777 or ERC20+ERC777). Resolves Consensys#58.
|
@pcardune – would appreciate your feedback here! |
|
I very much support keeping erc nomenclature. Nori is a heavy consumer of 820 |
|
I like this direction. I still need to play around with some of these decoder APIs to form a stronger opinion about how it should work. |
|
@pcardune @jaycenhorton – thanks for the feedback. I'm currently working on #59 which will add log decoding support shortly. Once that is in place, I'm resuming #44 because I'm solidifying a proposal in my head that I think meets all expectations. |
|
Positive feedback received from the community. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An entity groups related ERC standards, providing an abstraction on what kind of concept they refer to. In this way, different token interfaces can co-exist while making it easy to filter for all token transactions in a block, regardless of the underlying ERC interface (e.g. ERC20, ERC777 or ERC20+ERC777).
Altogether, I've decided against my original proposal of removing ERC20 nomenclature from types. Reading ERC820, made me realise that the differentiation is important when queries refer to transactions and logs, both of which adhere to a concrete ABI.
In fact, ERC820 makes the ERC number a first-class citizen in the registry, as keys take the form
ERC20Token,ERC777Token, etc.For me it was important to realise that some ERC introduce entities (e.g. ERC20), while others extend or alter those entities (ERC223). Those changes could impact the ABI or not. In the case of ERC223, it has no bearing on the ABI.
I've added a
README.mdin theabidirectory to serve as a registry of all ABIs we support, and how we regard them.Resolves #58.