Fix #61, #51 #62
Closed
Fix #61, #51 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So you've found that the bottleneck was the lexer? (In 99320fa) I assume that's why |
|
Also, is there a reason you chose a different color scheme for the output in the REPL than the scheme which colors the input?
|
|
@ConorOBrien-Foxx Well, the output currently displays as Ruby objects, making things consistent would be a very good idea but I'm not sure what would be the best way to do that |
|
@ConorOBrien-Foxx Yeah, the bottleneck is still the lexer, looks like one way would be to combine the regexes (doable, but might be a bit messy) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix issues #61 and #51.