-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add read permission for kataconfig #618
base: master
Are you sure you want to change the base?
Conversation
Hi @sluetze. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
🤖 To deploy this PR, run the following command:
|
9892bce
to
485aeb9
Compare
🤖 To deploy this PR, run the following command:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
CO can check the resources referenced content PR.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sluetze, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@sluetze: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test e2e-aws-parallel |
This PR adds permissions to read the kataconfigs for the api-resource-collector.
This is related to a complianceascode/content PR which checks, that a proper isolation between containers is guaranteed
first I only changed the file under config/rbac but this let the tests fail. so I followed what was done in:
90eb2a7
this might or might not be the correct way, but fixes the failing test :)