Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinUI libraries should support down to 17763 (1809) #4603

Open
2 of 3 tasks
michael-hawker opened this issue Jul 13, 2022 · 7 comments
Open
2 of 3 tasks

WinUI libraries should support down to 17763 (1809) #4603

michael-hawker opened this issue Jul 13, 2022 · 7 comments
Assignees
Labels
build 🔥 feature request 📬 A request for new changes to improve functionality hotfix 🌶 nuget 📦 WinUI 💠 Related to WinUI 3 Version or when paired with External can mean requires fix in WinUI 2/3.
Milestone

Comments

@michael-hawker
Copy link
Member

michael-hawker commented Jul 13, 2022

Describe the problem

Looks like with ProjectReunion originally only down to 18362 was supported, so that's what we used for our CommunityToolkit.WinUI packages. However, with the change and release of 1.x of the WindowsAppSDK down to 17763 is supported.

We just never noticed this change and aligned our packages. We should do this as we still should plan to support the 17763 LTS version for a bit until the new LTS version gains traction.

This would help us with labs as well for using Toolkit dependencies as we would like to be consistent on 17763 there as well. We should look into a 7.1.3 release with this change.

Describe the solution

Adjust the min version of our WinUI branch to 17763.

Requires updates to our dependencies:

Alternatives

No response

Additional info

@azchohfi see any concerns or issues with this?

Help us help you

Yes, but only if others can assist.

@michael-hawker michael-hawker added feature request 📬 A request for new changes to improve functionality nuget 📦 build 🔥 WinUI 💠 Related to WinUI 3 Version or when paired with External can mean requires fix in WinUI 2/3. hotfix 🌶 labels Jul 13, 2022
@ghost
Copy link

ghost commented Jul 13, 2022

Hello, 'michael-hawker! Thanks for submitting a new feature request. I've automatically added a vote 👍 reaction to help get things started. Other community members can vote to help us prioritize this feature in the future!

@azchohfi
Copy link
Contributor

No concerns.

@michael-hawker michael-hawker added this to the 7.1.3 milestone Jul 14, 2022
@Arlodotexe Arlodotexe self-assigned this Aug 23, 2022
@Arlodotexe Arlodotexe moved this to In Progress in Windows Community Toolkit Aug 23, 2022
@michael-hawker
Copy link
Member Author

We'll want to update to .NET 6 and the latest 1.1.4 WindowsAppSDK package.

@michael-hawker
Copy link
Member Author

Right now the following dependencies have 18362 (19H1) as a minimum:

  • ColorCode
  • XAML Behaviors
  • Win2D

@michael-hawker
Copy link
Member Author

Add links to tracking issues on dependencies to original post.

@michael-hawker
Copy link
Member Author

XAML Behaviors and Win2D have shipped. So we should be good to update our version in the pipeline once we update ColorCode for ourselves.

@michael-hawker
Copy link
Member Author

This has been blocked by CommunityToolkit/ColorCode-Universal#28 - something changed in the environment the CI runs and we can't build. I have been unable to find any information on the issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build 🔥 feature request 📬 A request for new changes to improve functionality hotfix 🌶 nuget 📦 WinUI 💠 Related to WinUI 3 Version or when paired with External can mean requires fix in WinUI 2/3.
Projects
Status: In Progress
Development

No branches or pull requests

3 participants