-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed and completed implementation of multitargeted project dependency system #196
Conversation
@Arlodotexe looks like a build failure for the template. Can you explain what the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my biggest question is I don't see where the Dependencies.props
is getting referenced for inclusion anywhere?
common/CommunityToolkit.Labs.Shared/Renderers/Markdown/MarkdownTextBlock.cs
Outdated
Show resolved
Hide resolved
@michael-hawker The switch between WinUI 2 and 3 in #139 used the property |
We need a guard for uno around this:
|
It's working locally, strange. I'll resolve the compiler errors soon. So far in this PR, I've focused on implementing the feature using things I know 100% will work as expected, which resulted in needing to use 3 files instead of just 1 for PackageReferences. However, using my notes here, I might have a way to combine them all into 1 file again while avoiding specific MSBuild quirks that have caused issues in the past. I'm testing it locally first to make sure it works. |
Still working to resolve the build errors, locally before pushing. |
platforms/CommunityToolkit.Labs.Wasm/CommunityToolkit.Labs.Wasm.csproj
Outdated
Show resolved
Hide resolved
… top of our #198 work
We'll be using #199 instead |
This PR:
llama/markdown
as a base (see [Sample App] Markdown Renderer Polyfill #151)UseTargetFrameworks.ps1
where it could only be used when in the same directory