Apply suggestions from code review

CommunityToolkit · Nov 9, 2020 · eb61e6d · eb61e6d
1 parent 55944ef
commit eb61e6d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/samples.json b/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/samples.json
@@ -48,7 +48,7 @@
         "Name": "ColorPickerButton",
         "Type": "ColorPickerButtonPage",
         "Subcategory": "Input",
-        "About": "A color picker within a flyout opened by pressing a drop down button containing the selected color.",
+        "About": "A color picker within a flyout opened by pressing a dropdown button containing the selected color.",
         "CodeUrl": "https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/master/Microsoft.Toolkit.Uwp.UI.Controls/ColorPicker",
         "XamlCodeFile": "/SamplePages/ColorPicker/ColorPickerButtonXaml.bind",
         "Icon": "/SamplePages/ColorPicker/ColorPicker.png",

diff --git a/Microsoft.Toolkit.Uwp.UI.Controls/ColorPicker/ColorPicker.cs b/Microsoft.Toolkit.Uwp.UI.Controls/ColorPicker/ColorPicker.cs
@@ -1378,7 +1378,7 @@ private void PreviewBorder_PointerPressed(object sender, Windows.UI.Xaml.Input.P
 
         /// <summary>
         /// Event handler for when a key is pressed within the Hex RGB value TextBox.
-        /// This is used to trigger re-evaluation of the color based on the TextBox value.
+        /// This is used to trigger a re-evaluation of the color based on the TextBox value.
         /// </summary>
         private void HexInputTextBox_KeyDown(object sender, Windows.UI.Xaml.Input.KeyRoutedEventArgs e)
         {
@@ -1402,7 +1402,7 @@ private void HexInputTextBox_KeyDown(object sender, Windows.UI.Xaml.Input.KeyRou
 
         /// <summary>
         /// Event handler for when the Hex RGB value TextBox looses focus.
-        /// This is used to trigger re-evaluation of the color based on the TextBox value.
+        /// This is used to trigger a re-evaluation of the color based on the TextBox value.
         /// </summary>
         private void HexInputTextBox_LostFocus(object sender, RoutedEventArgs e)
         {
@@ -1423,7 +1423,7 @@ private void HexInputTextBox_LostFocus(object sender, RoutedEventArgs e)
 
         /// <summary>
         /// Event handler for when a key is pressed within a color channel TextBox.
-        /// This is used to trigger re-evaluation of the color based on the TextBox value.
+        /// This is used to trigger a re-evaluation of the color based on the TextBox value.
         /// </summary>
         private void ChannelTextBox_KeyDown(object sender, Windows.UI.Xaml.Input.KeyRoutedEventArgs e)
         {
@@ -1436,8 +1436,8 @@ private void ChannelTextBox_KeyDown(object sender, Windows.UI.Xaml.Input.KeyRout
         }
 
         /// <summary>
-        /// Event handler for when a color channel TextBox looses focus.
-        /// This is used to trigger re-evaluation of the color based on the TextBox value.
+        /// Event handler for when a color channel TextBox loses focus.
+        /// This is used to trigger a re-evaluation of the color based on the TextBox value.
         /// </summary>
         private void ChannelTextBox_LostFocus(object sender, RoutedEventArgs e)
         {
@@ -1481,4 +1481,4 @@ private void ChannelSlider_ValueChanged(object sender, RangeBaseValueChangedEven
             return;
         }
     }
-}
+}
diff --git a/Microsoft.Toolkit.Uwp.UI.Controls/ColorPicker/ColorPicker.xaml b/Microsoft.Toolkit.Uwp.UI.Controls/ColorPicker/ColorPicker.xaml
@@ -414,7 +414,7 @@
                 <!--
                     The -1 and +1 accent preview originally had a drop shadow as well.
                     However, due to Z-order issues with the checkered background,
-                    shadow and preview border, it would have required it's own
+                    shadow and preview border, it would have required its own
                     checkered background. This was judged not worth the performance
                     trade-off so shadows were removed.
                 -->
@@ -1338,4 +1338,4 @@
 
     </ControlTemplate>
 
-</ResourceDictionary>
+</ResourceDictionary>
diff --git a/Microsoft.Toolkit.Uwp.UI.Controls/SwitchPresenter/SwitchPresenter.cs b/Microsoft.Toolkit.Uwp.UI.Controls/SwitchPresenter/SwitchPresenter.cs
@@ -152,7 +152,7 @@ private void EvaluateCases()
             {
                 if (xcase.IsDefault)
                 {
-                    // If there are multiple default cases provided, this'll override and just grab the last one, the developer will have to fix this in their XAML. We call this out in the case comments.
+                    // If there are multiple default cases provided, this will override and just grab the last one, the developer will have to fix this in their XAML. We call this out in the case comments.
                     xdefault = xcase;
                     continue;
                 }