-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: ColorPicker Binding failed #579
Merged
michael-hawker
merged 6 commits into
CommunityToolkit:main
from
Poker-sang:fix-colorpicker-binding-failed
Dec 21, 2024
Merged
Fix: ColorPicker Binding failed #579
michael-hawker
merged 6 commits into
CommunityToolkit:main
from
Poker-sang:fix-colorpicker-binding-failed
Dec 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arlodotexe
reviewed
Dec 5, 2024
components/ColorPicker/src/Converters/NullToTransparentConverter.cs
Outdated
Show resolved
Hide resolved
Arlodotexe
reviewed
Dec 5, 2024
components/ColorPicker/src/Converters/NullToTransparentConverter.cs
Outdated
Show resolved
Hide resolved
components/ColorPicker/src/Converters/NullToTransparentConverter.cs
Outdated
Show resolved
Hide resolved
michael-hawker
approved these changes
Dec 20, 2024
Looks like the latest CI error is:
Rerunning, let's see if it's consistent. |
Arlodotexe
reviewed
Dec 21, 2024
components/ColorPicker/src/Converters/NullToTransparentConverter.cs
Outdated
Show resolved
Hide resolved
Arlodotexe
approved these changes
Dec 21, 2024
For some reason only the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GridView.SelectedValue
to null is transient behavior. It does not affect the originalColorPicker
behavior.Fixes
closes: #414
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information