Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ColorPicker Binding failed #579

Merged

Conversation

Poker-sang
Copy link
Contributor

GridView.SelectedValue to null is transient behavior. It does not affect the original ColorPicker behavior.

Fixes

closes: #414

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

image

image

What is the new behavior?

image

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

@michael-hawker michael-hawker added this to the 8.2 milestone Dec 19, 2024
@michael-hawker michael-hawker enabled auto-merge (squash) December 20, 2024 23:42
@Arlodotexe
Copy link
Member

Arlodotexe commented Dec 21, 2024

Looks like the latest CI error is:

       "C:\a\Windows\Windows\tooling\ProjectHeads\AllComponents\Uwp\CommunityToolkit.App.Uwp.csproj" (default target) (56:6) ->
       (BuildNativePackage target) -> 
         C:\Program Files (x86)\Microsoft SDKs\UWPNuGetPackages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0001: [MarshalAs(UnmanagedType=(Default), ElementType=(Default))] with type 'Microsoft.DiaSymReader.VariantStructure' is not supported.This signature is located on 'System.Void Microsoft.DiaSymReader.ISymUnmanagedWriter5.DefineConstant2(System.String, Microsoft.DiaSymReader.VariantStructure, System.Int32)'. [C:\a\Windows\Windows\tooling\ProjectHeads\AllComponents\Uwp\CommunityToolkit.App.Uwp.csproj]
         C:\Program Files (x86)\Microsoft SDKs\UWPNuGetPackages\microsoft.net.native.compiler\2.2.12-rel-31116-00\tools\Microsoft.NetNative.targets(809,5): warning :       MCG : warning MCG0007: Unresolved P/Invoke method 'Microsoft.DiaSymReader.Native.x86.dll!CreateSymReader' for method 'System.Void Microsoft.DiaSymReader.SymUnmanagedFactory.CreateSymReader32(System.Guid, System.Object)'. Calling this method would throw exception at runtime. Please make sure the P/Invoke either points to a Windows API allowed in UWP applications, or a native DLL that is part of the package. If for some reason your P/Invoke does not satisfy those requirements, please use [DllImport(ExactSpelling=true) to indicate that you understand the implications of using non-UWP APIs. [C:\a\Windows\Windows\tooling\ProjectHeads\AllComponents\Uwp\CommunityToolkit.App.Uwp.csproj]

Rerunning, let's see if it's consistent.

@Arlodotexe
Copy link
Member

For some reason only the android target threw this error, but it'll need to be fixed:

       "D:\a\Windows\Windows\components\ColorPicker\src\CommunityToolkit.WinUI.Controls.ColorPicker.csproj" (Build target) (9:18) ->
       (CoreCompile target) -> 
         D:\a\Windows\Windows\components\ColorPicker\src\Converters\NullToTransparentConverter.cs(7,22): error CS1591: Missing XML comment for publicly visible type or member 'NullToTransparentConverter' [D:\a\Windows\Windows\components\ColorPicker\src\CommunityToolkit.WinUI.Controls.ColorPicker.csproj::TargetFramework=net9.0-android]
         D:\a\Windows\Windows\components\ColorPicker\src\Converters\NullToTransparentConverter.cs(9,19): error CS1591: Missing XML comment for publicly visible type or member 'NullToTransparentConverter.Convert(object, Type, object, string)' [D:\a\Windows\Windows\components\ColorPicker\src\CommunityToolkit.WinUI.Controls.ColorPicker.csproj::TargetFramework=net9.0-android]
         D:\a\Windows\Windows\components\ColorPicker\src\Converters\NullToTransparentConverter.cs(11,19): error CS1591: Missing XML comment for publicly visible type or member 'NullToTransparentConverter.ConvertBack(object?, Type, object, string)' [D:\a\Windows\Windows\components\ColorPicker\src\CommunityToolkit.WinUI.Controls.ColorPicker.csproj::TargetFramework=net9.0-android]

@michael-hawker michael-hawker merged commit 97e0d39 into CommunityToolkit:main Dec 21, 2024
24 checks passed
@Poker-sang Poker-sang deleted the fix-colorpicker-binding-failed branch December 21, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

XAML Binding failed in ColorPicker
3 participants