-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiTarget Matrix for CI, support for solution generation #456
Conversation
Labs will need the same |
Weird actual test failure:
|
Seems to be #347, rekicking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just wondering if we can "simplify" some of the re-use between the jobs?
It should have output the *.nupkg for all packages to the path ./ we passed into the build script, but the ./*.nupkg wildcard failed to find them for artifact upload. Either our script copies nupkg to the given folder locally but not in CI, or `dotnet nuget push ./*.nupkg` failed to locate nupkg files output to the working directory. Let's see which one.
@michael-hawker Looks like the |
Yeah, these are settings in the repo, we all set to go then? I can switch them over. |
Issue introduced from #456
Issue introduced from #456
This PR
build
job, splitting intobuild
andpackage
.build
job is matrixed in line with the multitarget systempackage
job is not matrixed and has been refactored to use our./tooling/Build-Toolkit-Components.ps1
script.Prerequisite PR: CommunityToolkit/Tooling-Windows-Submodule#200