Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting TabbedCommandBar #243

Merged
merged 21 commits into from
Feb 7, 2024
Merged

Porting TabbedCommandBar #243

merged 21 commits into from
Feb 7, 2024

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Sep 25, 2023

This PR brings TabbedCommandBar from the old repository.

TabbedCommandBar

Changes:

  • New styling inline with WinUI 2.6+
  • Resolved a bug where the accent color of a contextual tab wouldn't update on theme change.

The new styling mimics the styling found in the Office apps:
image

Closes: #93

@niels9001 niels9001 changed the title 🚧 Porting TabbedCommandBar Porting TabbedCommandBar Oct 6, 2023
@michael-hawker michael-hawker added this to the 8.1 milestone Jan 9, 2024
@Arlodotexe
Copy link
Member

@niels9001 Looks like TabbedCommandBar isn't appearing on Wasm. The browser console shows the exception and call stack:
image

@michael-hawker
Copy link
Member

Looks like we should be ensuring to use the WinUI 2 MUX versions of controls everywhere vs. old WUX ones.

@Arlodotexe
Copy link
Member

Arlodotexe commented Jan 23, 2024

Latest on Wasm - In TabbedCommandBar, text is missing on the tabs and the cause is less clear. No errors in the console.

image

@Arlodotexe
Copy link
Member

I've moved the Wasm issue to a new ticket. We can close this PR once #320 closes and unblocks our CI.

@Arlodotexe Arlodotexe enabled auto-merge (rebase) January 23, 2024 20:22
@Arlodotexe Arlodotexe self-assigned this Jan 29, 2024
@Arlodotexe Arlodotexe merged commit f9ce94a into main Feb 7, 2024
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the niels9001/tabbedcommandbar branch February 7, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Port TabbedCommandBar
3 participants