Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ExcludeMultiTargets not working as expected #240

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Dec 23, 2024

This PR fixes an issue where the ExcludeMultiTargets parameter passed to UseTargetFrameworks.ps1 wasn't being reflected in the generated code.

This led to issues in our CI, which relies on this parameter to ensure that UWP does not build for WinUI 3, and vice versa.

Note the net9.0-windows10.0.19041 TFM, which is only used for the wasdk MultiTarget. This is the Uwp package, so this should not be here:
image

@Arlodotexe Arlodotexe enabled auto-merge (rebase) December 23, 2024 22:29
@Arlodotexe Arlodotexe self-assigned this Dec 23, 2024
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!!

@Arlodotexe Arlodotexe merged commit eb7c442 into main Dec 24, 2024
11 checks passed
@Arlodotexe Arlodotexe deleted the multitarget/fix/excludemultitargets branch December 24, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants