-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewired "Available" vs "Enabled" MultiTargets and TargetFrameworks #237
Merged
Arlodotexe
merged 9 commits into
main
from
multitarget/enabled-targetframework-overrides
Dec 23, 2024
Merged
Rewired "Available" vs "Enabled" MultiTargets and TargetFrameworks #237
Arlodotexe
merged 9 commits into
main
from
multitarget/enabled-targetframework-overrides
Dec 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etFrameworks. Lifted TFM toggling above TFM declarations into MultiTarget system, enables overriding "Available" TargetFrameworks properly per-project.
Sergio0694
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much cleaner 🙂
Needs #234 |
…etFrameworks. Lifted TFM toggling above TFM declarations into MultiTarget system, enables overriding "Available" TargetFrameworks properly per-project.
Arlodotexe
force-pushed
the
multitarget/enabled-targetframework-overrides
branch
from
December 21, 2024 00:21
a7ac78e
to
b7521ef
Compare
…://github.com/CommunityToolkit/Tooling-Windows-Submodule into multitarget/enabled-targetframework-overrides
…p-net9-support Add 'net9.0-windows10.0.26100.0' TFM to UWP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restructures our props to creating a clean distinction between these four traits:
This "lifting" of the TFM toggling above the TFM declaration and into the MultiTarget system enables overriding "Available" TargetFrameworks per-project, while still allowing it to be disabled if not supported (2) or requested (3).