Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewired "Available" vs "Enabled" MultiTargets and TargetFrameworks #237

Merged
merged 9 commits into from
Dec 23, 2024

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Dec 20, 2024

This restructures our props to creating a clean distinction between these four traits:

  • Available or Enabled
  • MultiTarget or TargetFramework
  1. Available TargetFrameworks. A list of static values declared by the tooling, these are the TargetFrameworks that can be enabled.
  2. Available MultiTargets. A list of static values provided by the component or current project. These are the MultiTargets that the component can support.
  3. Enabled MultiTargets. Dynamically provided by the user each time the solution or build scripts run.
  4. Enabled TargetFrameworks. Dynamically determined using 1, 2 and 3, these are the TargetFrameworks that get enabled for build.

This "lifting" of the TFM toggling above the TFM declaration and into the MultiTarget system enables overriding "Available" TargetFrameworks per-project, while still allowing it to be disabled if not supported (2) or requested (3).

…etFrameworks. Lifted TFM toggling above TFM declarations into MultiTarget system, enables overriding "Available" TargetFrameworks properly per-project.
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner 🙂

@Arlodotexe
Copy link
Member Author

Needs #234

…etFrameworks. Lifted TFM toggling above TFM declarations into MultiTarget system, enables overriding "Available" TargetFrameworks properly per-project.
@Arlodotexe Arlodotexe force-pushed the multitarget/enabled-targetframework-overrides branch from a7ac78e to b7521ef Compare December 21, 2024 00:21
@Arlodotexe Arlodotexe merged commit 5a12e3d into main Dec 23, 2024
11 checks passed
@Arlodotexe Arlodotexe deleted the multitarget/enabled-targetframework-overrides branch December 23, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants