Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable AoT for net8 in Release #190

Merged
merged 6 commits into from
May 18, 2024
Merged

Enable AoT for net8 in Release #190

merged 6 commits into from
May 18, 2024

Conversation

Arlodotexe
Copy link
Member

This PR contains the tooling changes needed to enable AoT functionality on net8/WinAppSdk:

  • Enables Aot when running under .NET 8 in release mode
  • Defines missing NET8_0_OR_GREATER compilation conditionals
  • Switches to net8 as the primary TFM for the WinAppSDK head

@Arlodotexe Arlodotexe self-assigned this May 11, 2024
@Arlodotexe Arlodotexe mentioned this pull request May 11, 2024
Merged
@Arlodotexe Arlodotexe enabled auto-merge (rebase) May 17, 2024 23:13
@Arlodotexe
Copy link
Member Author

Arlodotexe commented May 17, 2024 •
edited
Loading

The error message from the CI:

D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\ProjectTemplate\heads\Uwp\ProjectTemplate.Uwp.csproj : error NU1201: Project ProjectTemplateExperiment.Samples is not compatible with uap10.0.17763 (UAP,Version=v10.0.17763) / win10-arm-aot. Project ProjectTemplateExperiment.Samples supports: [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\tooling\ProjectTemplate\ProjectTemplate.sln]

Need to revert a bad change to the default target frameworks

@Arlodotexe
Copy link
Member Author

This PR also closes #183

@Arlodotexe Arlodotexe linked an issue May 18, 2024 that may be closed by this pull request
.NET 6 Runtime was required for use #183
Closed
20 tasks
@Arlodotexe Arlodotexe merged commit ce05388 into main May 18, 2024
7 of 8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the net8/aot branch May 18, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees

@Arlodotexe Arlodotexe

Labels
None yet
Projects
Toolkit 8.x
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.NET 6 Runtime was required for use
2 participants
@Arlodotexe @michael-hawker