Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated default sample icon #152

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

Arlodotexe
Copy link
Member

Closes #151

@michael-hawker
Copy link
Member

@niels9001 this look good to you? @Arlodotexe how does it look in the sample app compared to the other icons?

@niels9001
Copy link
Collaborator

@Arlodotexe @michael-hawker I've created a new placeholder icon that you can use (it's also 54px instead of 74px)

Placeholder

Put in a PR for updating the Labs components here: CommunityToolkit/Labs-Windows#510

@Arlodotexe Arlodotexe closed this Nov 9, 2023
@Arlodotexe Arlodotexe reopened this Nov 9, 2023
@Arlodotexe Arlodotexe enabled auto-merge (rebase) November 9, 2023 17:19
@Arlodotexe
Copy link
Member Author

@niels9001 this look good to you? @Arlodotexe how does it look in the sample app compared to the other icons?

Looks good, should be ready to close

image

@Arlodotexe
Copy link
Member Author

@michael-hawker Needs an approving review

@Arlodotexe Arlodotexe merged commit 0cc89a5 into main Nov 14, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the component-template/default-sample-icon branch November 14, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better default Icon / Replace Box icons for components
3 participants