Fix issue with sample displays being blank #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-hawker
added
bug 🐛
Arlodotexe
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CommunityToolkit/Windows#230
Not sure why we only found this out in Release mode, or I guess just from checking out on a fresh machine we used for the store build.
In either case, there was a problem where the
Environment.Newlinein C# didn't match the files being loaded by the Sample app (files seemed inconsistent which made it harder to diagnose as some samples did load).What was happening is because the Newline wasn't detected, the code added to strip extraneous header info off of the samples before display was instead just removing all the content.
This change makes it so we only split on the single newline character
\ninstead.