Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expander CollectionView GridLayout 1557 #1567

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

VladislavAntonyuk
Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk commented Nov 26, 2023

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

image

image

@VladislavAntonyuk VladislavAntonyuk requested a review from a team November 26, 2023 19:06
@VladislavAntonyuk VladislavAntonyuk self-assigned this Nov 26, 2023
@brminnick
Copy link
Collaborator

It looks like this fix only targets Windows. I'm seeing similar broken behavior on iOS + MacCatalyst with a CollectionView inside Expander.

Any chance you could take a look at the other platforms too?

@VladislavAntonyuk
Copy link
Collaborator Author

@brminnick as discussed at the meeting, I suggest merging it as it is (despite having some visual issues).

@ghost ghost added stale The author has not responded in over 30 days help wanted This proposal has been approved and is ready to be implemented labels Jan 15, 2024
@leoslima13
Copy link

@brminnick @VladislavAntonyuk Do you guys have any predictions on when this will be completed? We can see several people having exactly this expansion problem within the CollectionView, I think this would be a good time for that

@vhugogarcia
Copy link
Contributor

Thanks @VladislavAntonyuk for updating the expander under CollectionView and GridLayout.

I just tested it on Android and it works as expected, however it does not work on macOS and iOS (see screenshot below):

Android 1 macOS 2 iOS 3

On macOS/iOS, then you expand an item from the CollectionView all others disappear and it does not grow as expected. The same issue occurs on the horizontal items.

I will see if I can help with the macOS/iOS issue :)

@hayer
Copy link

hayer commented Mar 18, 2024

@vhugogarcia has there been any progress made on this for iOS/macOS? I am currently stuck with it not working on iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted This proposal has been approved and is ready to be implemented stale The author has not responded in over 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Expander does not resize properly inside CollectionView
5 participants