Don't use fallback APIs based on OS version when running on WinAppSDK #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffstall
previously approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lottie detects the version of the OS, and uses fallback codepaths when it detects that the needed API does not exist. This was good for UWP Lottie, but is unnecessary for WinAppSDK Lottie, since WinAppSDK bundles that code into the app and is not dependent on OS version.
Particularly, this was an issue when running on old OS versions that did not have proper pathing support. Lottie would detect the old OS and fall back to a type of pathing that does not work correctly, when that is unnecessary because WinAppSDK has the latest pathing updates.
This change hard-codes the contract version for WinAppSDK Lottie.