Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Add LottieIsland and LottieWinRT for frameworkless or native applications #557
base: main
Are you sure you want to change the base?
[DRAFT] Add LottieIsland and LottieWinRT for frameworkless or native applications #557
Changes from 33 commits
03637d8
15673a6
f715f7b
7d583f3
2669684
3e107ef
0329c09
9cf356a
567d126
aef4a7c
87525d0
e7a6d2f
381c02d
7263a34
807c32a
8fd5e6b
b41d8fd
66b537b
457d0b7
10d8542
623d418
ddcc1a6
144a389
af22bdc
7201843
95e6616
544cde6
8d9c060
5896c83
9e92f8e
1167c74
b40f53f
9a0ce7c
0840bbb
32e0e81
a542db3
05d2e1f
267afe5
f91bf4d
d8752d4
845f6f3
750f44c
81b8438
eac0dc2
0945863
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these just be configured on the ContentIsland directly? Why does it need to be exposed from this object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to allow a hosting application to hook into input to configure e.g. click to pause. We didn't want to have the hosting application directly calling InputPointerSource.GetForIsland
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No really, I'd like to remove it for now. We're already passing the ContentIsland out as a property. The app can call InputPointerSource.GetForIsland. Unless there's an important reason to wrap and re-expose all of this (e.g., something about object destruction), it's much better to not need to duplicate all of these APIs.