MarkdownTextBlock: Adds OnMarkdownParsed event #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerocui
approved these changes
Dec 4, 2024
azchohfi
reviewed
Dec 6, 2024
| @@ -116,6 +114,7 @@ private void ApplyText(bool rerender) | |||
| if (!string.IsNullOrEmpty(Text)) | |||
| { | |||
| this.MarkdownDocument = Markdown.Parse(Text, _pipeline); | |||
| OnMarkdownParsed?.Invoke(this, new MarkdownParsedEventArgs(this.MarkdownDocument)); | |||
There was a problem hiding this comment.
I believe there is a 1-1 relationship between MarkdownTextBlock and its MarkdownDocument, so I would remove the Document property from the MarkdownParsedEventArgs, as you can get that from the sender.
There was a problem hiding this comment.
Every time you change the Text property of MarkdownTextBlock, technically you would get a brand new MarkdownDocument tree. If we also move the parsing to another thread, technically there would be no guarantees that the MarkdownDocument currently set on the control is the one corresponding to the given event, especially in streaming contexts
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an event
MarkdownTextBlock.OnMarkdownParsed, which is useful because consumers cannot otherwise know when the MarkdownDocument has finished being generated from the markdown text input. It also technically allows consumers to mutate the markdown parsed tree before the render step takes place.