Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MarkdownTextBlock: Minor style improvements #604

Merged
merged 4 commits into from
Nov 27, 2024
Merged

MarkdownTextBlock: Minor style improvements #604

merged 4 commits into from
Nov 27, 2024

Conversation

jcoc611-microsoft
Copy link

Before:

image

After:

image

Changes:

  • Lists have proper margins before and after
  • List item bullets have proper padding and are right-aligned to the column
  • Thematic breaks now have 100% width rather than hard-coded to 500px
  • Headings now have proper margins before

@jcoc611-microsoft
Copy link
Author

Fixes some of the style issues mentioned in #547

@jcoc611-microsoft jcoc611-microsoft marked this pull request as draft November 25, 2024 21:05
@jcoc611-microsoft jcoc611-microsoft marked this pull request as ready for review November 26, 2024 18:10
@Arlodotexe Arlodotexe enabled auto-merge November 26, 2024 23:18
@Arlodotexe Arlodotexe merged commit e85d867 into CommunityToolkit:main Nov 27, 2024
20 of 21 checks passed
@jcoc611-microsoft jcoc611-microsoft deleted the user/juosori/StyleFixes1 branch December 6, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Toolkit 8.x
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcoc611-microsoft @Arlodotexe @niels9001