Fix DataTable crash on resize when columns don't fit #599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataTable
sometimes crashes on resize, typically when it gets narrow enough for its columns not to fit. Crash happens inMeasureOverride
because of negative value passed toSize
ctor.The easiest way to reproduce is to set
DataTable
'sHorizontalAlignment
toLeft
to disable "stretching" behavior. The following code snippet may be used (slightly modified version ofDataTableSample.xaml
):This PR adds a check to make sure width value used in
MeasureOverride()
are non-negative.