Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N°6282 Fix XSS vulnerability in soap #690

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

Timmy38
Copy link
Contributor

@Timmy38 Timmy38 commented Dec 16, 2024

No description provided.

@Timmy38 Timmy38 added the internal Work made by Combodo label Dec 16, 2024
@Timmy38 Timmy38 requested a review from rquetiez December 16, 2024 15:34
@Timmy38 Timmy38 force-pushed the issue/6282_fix_XSS_in_soap branch from 1ac7a41 to 9ae372f Compare December 16, 2024 15:54
@Timmy38 Timmy38 marked this pull request as draft December 16, 2024 15:57
@Timmy38 Timmy38 changed the base branch from develop to support/3.2 December 16, 2024 15:58
@Timmy38 Timmy38 marked this pull request as ready for review December 16, 2024 15:58
@Hipska
Copy link
Contributor

Hipska commented Dec 16, 2024

The parameter service_category is also used in other places like itop.wsdl.php.

I think it is best to think about deprecating the SOAP and providing a timeline on when it will be removed from iTop, so that it doesn't depend on php-soap anymore for installation.

@steffunky
Copy link
Member

I think it is best to think about deprecating the SOAP and providing a timeline on when it will be removed from iTop, so that it doesn't depend on php-soap anymore for installation.

We plan on deprecating SOAP in the 3.2 LTS branch and removing it right after, in the 3.3 branch 😁

@Timmy38 Timmy38 merged commit 42f3914 into support/3.2 Dec 19, 2024
@Timmy38 Timmy38 deleted the issue/6282_fix_XSS_in_soap branch December 19, 2024 10:39
@Hipska
Copy link
Contributor

Hipska commented Dec 19, 2024

Ouch, the vulnerability still isn't fixed in itop.wsdl.php as I pointed out before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Work made by Combodo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants