N°7385 - Trigger on mention executed even if it's not a mention with @

[accognet]

Internal

[Molkobain]

Review of the current proposition
Mentions are not only for Contact (@ marker by default), it can be for any kind of objects. So your current implementation breaks it for all other classes.

If we are to go further with this ticket, then we must check if the mentioned object matches the marker it begins with.

Use case that led to this PR
When pasting text from an iTop; if the text contains the hyperlink to an object with the same meta data as the mentions, then the mention will be triggered again even if the hyperlink doesn't start with the marker (@ for Contact).

@v-dumas had this behaviour recently and thought it was nice. So there is obviously a discussion to be done, so we all decide what behaviour we want.

[Molkobain]

I'm moving this PR to "Functional review" even though the technical one didn't occur yet, so the important point can be discussed before going any further.

[Molkobain]

Functional review:

• Expected behavior: Only trigger a mention, if the hyperlink starts with the corresponding marker (e.g. @ for Person)
• Target version: 3.2.x if code changes are not too risky, 3.3.0 otherwise. Will be determined, once PR is corrected