Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split public and private config/driver APIs #6024

Open
wants to merge 2 commits into
base: V3/develop
Choose a base branch
from
Open

Split public and private config/driver APIs #6024

wants to merge 2 commits into from
+47 −31

Conversation

Jackenmen
Copy link
Member

@Jackenmen Jackenmen commented Apr 15, 2023 •
edited
Loading

Description of the changes

Split out get_latest_confs() and migrate() from redbot.core.config to redbot.core._config module as they don't really have a sensible use outside our own code

Have the changes in this PR been tested?

Yes

@Jackenmen Jackenmen added Type: Enhancement Something meant to enhance existing Red features. Breaking Change Will potentially break some cogs. labels Apr 15, 2023
@github-actions github-actions bot added Category: Core - i18n This is related to the i18n core API or locale files. Category: Core - API - Config This is related to the `redbot.core.config` module and `redbot.core.drivers` package. Category: Core - Bot Class This is related to the `redbot.core.bot.Red` class. Category: Core - Command-line Interfaces This is related to Red's CLIs (redbot, redbot-launcher, redbot-setup). Category: Core - Other Internals This is related to core internals that don't have a dedicated label. Category: Meta This is related to the repository maintenance. labels Apr 15, 2023
@Jackenmen Jackenmen force-pushed the config_driver_api_changes_for_rarely_used branch 2 times, most recently from 6a1c33b to 0d9bbd7 Compare April 15, 2023 21:26
@Jackenmen Jackenmen added this to the 3.5.1 milestone Apr 15, 2023
@Jackenmen Jackenmen force-pushed the config_driver_api_changes_for_rarely_used branch from 0d9bbd7 to 3284654 Compare May 8, 2023 10:01
@Jackenmen Jackenmen removed the Breaking Change Will potentially break some cogs. label May 8, 2023
@github-actions github-actions bot removed Category: Core - i18n This is related to the i18n core API or locale files. Category: Core - Bot Class This is related to the `redbot.core.bot.Red` class. labels May 8, 2023
@Jackenmen Jackenmen changed the title Document and clarify publicity of rarely used config/driver APIs Split public and private config/driver APIs May 8, 2023
@Jackenmen Jackenmen modified the milestones: 3.5.3, 3.5.2, 3.6.0 May 11, 2023
@Jackenmen Jackenmen modified the milestones: 3.5.6, 3.5.7 Mar 18, 2024
@Jackenmen Jackenmen modified the milestones: 3.5.9, 3.5.10 Apr 20, 2024
@Jackenmen Jackenmen modified the milestones: 3.5.14, 3.5.x Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: Core - API - Config This is related to the `redbot.core.config` module and `redbot.core.drivers` package. Category: Core - Command-line Interfaces This is related to Red's CLIs (redbot, redbot-launcher, redbot-setup). Category: Core - Other Internals This is related to core internals that don't have a dedicated label. Category: Meta This is related to the repository maintenance. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
3.5.x
Development

Successfully merging this pull request may close these issues.
1 participant
@Jackenmen