-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PR titles made by prepare/publish release workflows #5990
base: V3/develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for taking the interest in improving our automation!
There are some things that need to be addressed before this can be merged:
[3.x]
prefix should only be added when the PRs are made against3.x
branches- I'd rather have a simple script using
actions/github-script
than use another action such asbooxmedialtd/ws-action-parse-semver
that you used, especially considering that it's not a widely used action. This should actually make it a lot easier to implement the logic for only adding a prefix when PR is against3.x
branch since it allows you to either return an empty string or appropriate"[3.x] "
prefix string and use that in the PR title and the commit message
In case it helps, here's an example of a PR that should have a prefix: and here's an example of a PR that should not have a prefix: |
b4176b0
to
7efa0c5
Compare
7efa0c5
to
c2a0c72
Compare
I realize that you're currently still working on this but I noticed that you're trying to use the value of |
Description of the changes
We have added an action in the .github/workflow/prepare_release.yml and .github/workflow/publish_release.yml files to display the PR title with the major and minor version prefix.
Fixes #5766
Have the changes in this PR been tested?
Yes