Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: phpstan issues #1881

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: phpstan issues #1881

merged 1 commit into from
Sep 25, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 25, 2023 •
edited
Loading

Closes #1880

Summary

Use empty function for content checking instead of isset.

Screenshots

Test instructions

Minor dev changes. Everything should work without no issue.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 25, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Sep 25, 2023
@Soare-Robert-Daniel
Copy link
Contributor Author

@HardeepAsrani, can we get this merged ASAP so as not to create a failing test when syncing development with other PR

@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review September 25, 2023 10:06
@pirate-bot
Copy link
Contributor

Plugin build for a9b7491 is ready 🛎️!

@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 274.83 KB 274.83 KB 0 B (0.00%)
Blocks 1.47 MB 1.47 MB 0 B (0.00%)
CSS 89.3 KB 89.3 KB 0 B (0.00%)
Dashboard 129.72 KB 129.72 KB 0 B (0.00%)
Export Import 87.19 KB 87.19 KB 0 B (0.00%)
Pro 346.75 KB 346.75 KB 0 B (0.00%)

@HardeepAsrani
Copy link
Member

@Soare-Robert-Daniel Can you detail the features we changed in code and put it through a quick QA?

@pirate-bot
Copy link
Contributor

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 72.79 12.63 72.31 10.53 (60ms) 73.68 (80ms)
Values above 60ms "0 - 69.37, 2 - 76.43, 4 - 61.13, 5 - 62.89, 6 - 74.05, 7 - 67.96, 8 - 60.41, 9 - 104.38, 10 - 95.93, 11 - 72.31, 12 - 84.08, 13 - 73.26, 14 - 63.48, 15 - 81.87, 16 - 77.76, 17 - 66.40, 18 - 80.48"

@HardeepAsrani HardeepAsrani merged commit c815809 into development Sep 25, 2023
30 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/phpstan-update branch September 25, 2023 13:26
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added released Indicate that an issue has been resolved and released in a particular version of the product. pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HardeepAsrani HardeepAsrani HardeepAsrani approved these changes

Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Soare-Robert-Daniel @pirate-bot @HardeepAsrani