Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPStan errors #1880

Closed
HardeepAsrani opened this issue Sep 25, 2023 · 1 comment
Closed

Fix PHPStan errors #1880

HardeepAsrani opened this issue Sep 25, 2023 · 1 comment
Assignees
@Soare-Robert-Daniel
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@HardeepAsrani
Copy link
Member

Description

We updated a few dependencies, and that seems like WP PHP stan checks have added new rules that are making the build fail. We can fix those, one example: https://github.com/Codeinwp/otter-blocks/actions/runs/6296871655/job/17092702575?pr=1879

Step-by-step reproduction instructions

You can see it in any PR on in dev branch.

Screenshots, screen recording, code snippet or Help Scout ticket

https://github.com/Codeinwp/otter-blocks/actions/runs/6296871655/job/17092702575?pr=1879

Environment info

No response

Is the issue you are reporting a regression

No
@HardeepAsrani HardeepAsrani added the bug This label could be used to identify issues that are caused by a defect in the product. label Sep 25, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Sep 25, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this issue Sep 25, 2023
Merged
9 tasks
@HardeepAsrani HardeepAsrani mentioned this issue Sep 25, 2023
Merged
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HardeepAsrani @Soare-Robert-Daniel @pirate-bot