Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix latest compiler #18

Merged
merged 3 commits into from
Oct 30, 2024
Merged

fix latest compiler #18

merged 3 commits into from
Oct 30, 2024

Conversation

YiraSan
Copy link
Contributor

@YiraSan YiraSan commented Oct 30, 2024

there's a little miss

src/aio/posix/windows.zig Outdated Show resolved Hide resolved
@Cloudef
Copy link
Owner

Cloudef commented Oct 30, 2024

This won't fix windows builds due to the zigwin32 dep, but it's still required anyways.

@YiraSan
Copy link
Contributor Author

YiraSan commented Oct 30, 2024

kcbanner/zigwin32gen@dc066ce

Also, why not using this fixing commit directly in build.zig.zon while waiting for zigwin32 to be officially fixed ?

@Cloudef
Copy link
Owner

Cloudef commented Oct 30, 2024

Sure, you can add that to this pr

Waiting for official to be fixed for 0.14.0-dev
@Cloudef Cloudef merged commit 1a54221 into Cloudef:master Oct 30, 2024
2 checks passed
@YiraSan
Copy link
Contributor Author

YiraSan commented Oct 30, 2024

I'm a big idiot, I used zigwin32gen instead of zigwin32 :')
I was committing that idiot fix litterally 1 sec after you merged
Sorry so much !!!!

@Cloudef
Copy link
Owner

Cloudef commented Oct 30, 2024

There is no action checks for windows builds yet, so just send a new pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants