-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prescribed thermo for AIDA calibrations #487
Conversation
I would vote for not fitting any lines then and just driving it with what is in the measurements. We can interpolate between the two points in time from the measurements to get the rate at each time step |
0ab1f1b
to
934d4b9
Compare
c3a3603
to
705e893
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 41 41
Lines 1605 1605
=======================================
Hits 1538 1538
Misses 67 67
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the AIDA_rate
function. Maybe something like this would be nicer?
import Interpolations as Intp
# example values
FT = Float32
t_in = FT[0.130, 0.464, 0.573, 1.100, 1.653, 2.216, 2.760]
p_in = FT[991.3, 954.2, 942.0, 886.9, 831.5, 778.9, 729.8]
p_of_t = Intp.linear_interpolation(t_in, p_in)
p = p_of_t(0.5)
Then you could compute the gradient for any t
and dt
combination?
5666393
to
61b34e7
Compare
1e0bb97
to
6988f3b
Compare
3594502
to
3cb3864
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Changing AIDA calibrations for HOM so that we are prescribing cooling rate and pressure.