Try fixing 1M scheme for ClimaAtmos #418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClimaAtmos 1-moment simulations don't work with the new release of CloudMicrophysics (v0.21). I tracked it down to us changing the "do nothing" condition in 1-moment microphysics scheme from
FT(0)
toeps(FT)
.This PR reverts the changes. I will make a new release for CloudMicrophysics after it is merged (and ideally also #417 and #415 )