Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing 1M scheme for ClimaAtmos #418

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Try fixing 1M scheme for ClimaAtmos #418

merged 1 commit into from
Jul 3, 2024

Conversation

trontrytel
Copy link
Member

ClimaAtmos 1-moment simulations don't work with the new release of CloudMicrophysics (v0.21). I tracked it down to us changing the "do nothing" condition in 1-moment microphysics scheme from FT(0) to eps(FT).

This PR reverts the changes. I will make a new release for CloudMicrophysics after it is merged (and ideally also #417 and #415 )

@trontrytel
Copy link
Member Author

cc @szy21 - This should fix Atmos simulations

@szy21
Copy link
Member

szy21 commented Jul 2, 2024

Thanks! It's interesting that this makes a difference to stability. Maybe eps(Float32) is too large as a threshold for things like q_rai?

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (f73555a) to head (69c170a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   97.01%   96.94%   -0.07%     
==========================================
  Files          37       37              
  Lines        1440     1440              
==========================================
- Hits         1397     1396       -1     
- Misses         43       44       +1     
Components Coverage Δ
src 98.88% <100.00%> (-0.08%) ⬇️
ext 69.79% <ø> (ø)

Copy link
Contributor

@crocicc crocicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me Anna! Considering that eps(Float32) is quite large, it will even make the computation of radar reflectivity more accurate; so thank you so much for this!

@trontrytel
Copy link
Member Author

Agreed. I think for Float32 its not a good condition for our water tracers. One way around it would be to consider not using base SI units for some of the microphysics variables. But for now I'll make sure that the schemes we use in Atmos use FT(0)

@trontrytel trontrytel force-pushed the aj/debug_for_atmos branch from 69c170a to 6809269 Compare July 3, 2024 00:11
@trontrytel trontrytel enabled auto-merge July 3, 2024 00:12
@trontrytel trontrytel merged commit fd9dac0 into main Jul 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants