Skip to content

Commit

Permalink
Merge pull request #395 from CliMA/aj/aero_constructor
Browse files Browse the repository at this point in the history 
remove unnecessary constructors
  • Loading branch information
@trontrytel
trontrytel authored May 10, 2024
2 parents c156fb3 + ab68760 commit 10505a9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 45 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "CloudMicrophysics"
uuid = "6a9e3e04-43cd-43ba-94b9-e8782df3c71b"
authors = ["Climate Modeling Alliance"]
version = "0.20.0"
version = "0.20.1"

[deps]
ClimaParams = "5c42b081-d73a-476f-9059-fd94b934656c"
Expand Down
44 changes: 0 additions & 44 deletions src/AerosolModel.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,30 +44,6 @@ struct Mode_B{T, FT}
aerosol_density::T
end

function Mode_B(
r_dry::FT,
stdev::FT,
N::FT,
mass_mix_ratio::T,
soluble_mass_frac::T,
osmotic_coeff::T,
molar_mass::T,
dissoc::T,
aerosol_density::T,
) where {T, FT}
return Mode_B{T, FT}(
r_dry,
stdev,
N,
mass_mix_ratio,
soluble_mass_frac,
osmotic_coeff,
molar_mass,
dissoc,
aerosol_density,
)
end

""" number of components in the mode """
n_components(::Mode_B{T}) where {T <: Tuple} = fieldcount(T)
n_components(::Mode_B{T}) where {T <: Real} = 1
Expand Down Expand Up @@ -99,26 +75,6 @@ struct Mode_κ{T, FT}
kappa::T
end

function Mode_κ(
r_dry::FT,
stdev::FT,
N::FT,
vol_mix_ratio::T,
mass_mix_ratio::T,
molar_mass::T,
kappa::T,
) where {T, FT}
return Mode_κ{T, FT}(
r_dry,
stdev,
N,
vol_mix_ratio,
mass_mix_ratio,
molar_mass,
kappa,
)
end

""" number of components in the mode """
n_components(::Mode_κ{T}) where {T <: Tuple} = fieldcount(T)
n_components(::Mode_κ{T}) where {T <: Real} = 1
Expand Down

2 comments on commit 10505a9

@trontrytel
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/106591

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.20.1 -m "<description of version>" 10505a9615728b3688f9ce0b561abd8f11cef2b2
git push origin v0.20.1

Please sign in to comment.