Enable Modal for Themes #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine to keep the js and css as a single file if they work for both. About |
…oid search box getting hidden
… avoid search box getting hidden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the use of a modal for themes. I have also changed a function name in
PluginInstall.class.phpto reflect the fact that I use the same function for themes.I have NOT included a CSS or JS file here because I tried duplicating
plugin-page.jsandplugin-page.cssfor themes and they both worked perfectly without me changing anything. So I wanted to ask whether you still want me to add both files, or whether you might instead just renameplugin-page.jsandplugin-page.cssand use them for both plugins and themes.