Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: client-admin upgrade to react router v6 #51

Open
wants to merge 1 commit into
base: edge-civictechto
Choose a base branch
from

Conversation

thomassth
Copy link

@thomassth thomassth commented Oct 22, 2024

npm audit --prod should now report no vulns.

@thomassth thomassth changed the title client-admin upgrade to react router v6 feature/client-admin upgrade to react router v6 Oct 22, 2024
@thomassth thomassth changed the title feature/client-admin upgrade to react router v6 Feature: client-admin upgrade to react router v6 Oct 22, 2024
@thomassth thomassth force-pushed the client-admin-react-router branch from e7b1529 to 59ed95a Compare October 22, 2024 07:00
@NewJerseyStyle NewJerseyStyle linked an issue Oct 26, 2024 that may be closed by this pull request
@MaanasArora
Copy link

@thomassth I cloned the project and tried to validate it!

I see only 1 high-severity vulnerability, perhaps because some modules were updated after this PR was made:

path-to-regexp  0.2.0 - 1.8.0
Severity: high
path-to-regexp outputs backtracking regular expressions - https://github.com/advisories/GHSA-9wv6-86v2-598j
fix available via `npm audit fix`
node_modules/react-router/node_modules/path-to-regexp

I've updated express in a branch on my fork that fixes this issue, though I'm not sure if we're willing to update express for backward compatibility (and not tested the implementation fully).

Looks good to me otherwise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client-admin: update react-router
2 participants