Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: open participation page accessibility issues (Axe) #32

Merged
merged 11 commits into from
Oct 18, 2024
Merged

Fix: open participation page accessibility issues (Axe) #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e243833
Fixed issue with Makefile prefixing extra whitespace to envvars and f…
patcon Oct 17, 2024
d350855
Merge pull request #34 from patcon/33-makefile-fix
NewJerseyStyle Oct 17, 2024
6498485
increase text contrast
thomassth Oct 17, 2024
40a6349
increase footer text contrast
thomassth Oct 17, 2024
7893aee
HTML landmarks, h1 heading
thomassth Oct 17, 2024
81988d1
add title to document
thomassth Oct 17, 2024
ab1330a
increase active primary button contrast
thomassth Oct 17, 2024
bd9c197
increase submit button contrast
thomassth Oct 18, 2024
c5cfbc4
remove unnecessary form role
thomassth Oct 18, 2024
6f7a5af
Merge branch 'edge-civictechto' into participation-a11y
patcon Oct 18, 2024
ff39e84
Apply suggestions from code review
thomassth Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions client-participation/js/templates/comment-form.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@


<form
role="form"
style="padding-bottom: 1px; {{! no stripe of background_content color mobile }}
">

Expand Down Expand Up @@ -235,7 +234,7 @@
cursor: pointer;
border: none;
border-radius: 4px;
background-color: #0090ff;
background-color: #0076D1;
color: white;
letter-spacing: 0.07em;
min-width: 110px;
Expand Down
4 changes: 2 additions & 2 deletions client-participation/js/templates/link-TOS-partial.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
target="_blank"
style="
font-family: Georgia;
color: rgb(150,150,150);
color: rgb(87,87,87);
font-size: 18px;
letter-spacing: 2px;">
{{s.TOS}}
</a>
</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: pls revert (will explain later)

5 changes: 3 additions & 2 deletions client-participation/js/templates/link-privacy-partial.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
target="_blank"
style="
font-family: Georgia;
color: rgb(150,150,150);
color: rgb(87,87,87);
font-size: 18px;
letter-spacing: 2px;
margin-inline-end: 5px;
">{{s.privacy}}</a>
"
>{{s.privacy}}</a>
Comment on lines +12 to +13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: pls revert (will explain later)

18 changes: 8 additions & 10 deletions client-participation/js/templates/participation.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
{{/ifNotEmbedded}}


<span id="header_root"></span>
<header id="header_root"></header>

<div
<main
class="
conversationViewRoot
clickDeselectsHull
Expand Down Expand Up @@ -168,7 +168,7 @@

{{#unless no_topic}}
{{#ifDefined topic}}
<h2
<h1
thomassth marked this conversation as resolved.
Show resolved Hide resolved
class="HeadingA"
style="
margin-bottom: 10px;
Expand All @@ -189,7 +189,7 @@
left: 6px;
">closed</span>
thomassth marked this conversation as resolved.
Show resolved Hide resolved
{{/unless}}
</h2>
</h1>
{{/ifDefined}}
{{/unless}}

Expand Down Expand Up @@ -431,13 +431,13 @@

</span> {{!-- end no_vis toggle wrapper --}}


</main> {{! END PARTICIPATION VIEW DIV }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify what's happening here? Was it malformed before, and you're fixing it? This might need an explicity explanation in your upstream PR as well :)

Copy link
Author

@thomassth thomassth Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm separating footer from main to better match the standard.

No change in content otherwise.



{{! ------------ BEGIN FOOTER --------------- }}
{{#unless no_footer}}

<div style="margin-top: 40px; margin-bottom: 20px;" data-test-footer>
<footer style="margin-top: 40px; margin-bottom: 20px;" data-test-footer>
<a href="https://pol.is" target="_blank" dir="auto">
{{> logo}}
</a>
Expand All @@ -450,7 +450,7 @@
{{> linkPrivacy}}
{{> linkTos}}
</div>
</div>
</footer>

{{!-- <div style="font-size:18px;font-weight:400;color:white;background-color:#03a9f4;display:flex;-webkit-flex-direction:row;-webkit-flex-wrap:nowrap;-webkit-justify-content:space-between;-webkit-align-items:baseline;-webkit-align-content:stretch;-webkit-order:0;-webkit-flex-grow:0;-webkit-flex-shrink:1;-webkit-flex-basis:auto;-webkit-align-self:auto;" data-reactid=".0.0.$=1$=012.0">
<p style="margin-inline-start:20px;font-size:12px;" data-reactid=".0.0.$=1$=012.0.$=1$/=010">© The Authors. 2016 </p>
Expand All @@ -466,6 +466,4 @@
</div> --}}
{{/unless}}
{{! END FOOTER}}
{{! ------------ END FOOTER --------------- }}

</div> {{! END PARTICIPATION VIEW DIV }}
{{! ------------ END FOOTER --------------- }}
Loading
Loading