Skimmer effect while fetching featured circuits #57
Conversation
Bringup Featured Circuits (CircuitVerse#37)
Added Focus Nodes (CircuitVerse#39)
pulling changes
pulling changes
UI Test: EditProfileView: Fix Test (CircuitVerse#46)
Pull Request Test Coverage Report for Build 522663498
💛 - Coveralls |
lib/ui/components/cv_skimmer.dart
Outdated
| enum ShimmerDirection { ltr, rtl, ttb, btt } | ||
|
|
||
| @immutable | ||
| class Shimmer extends StatefulWidget { |
There was a problem hiding this comment.
Class name and file name should follow the same name.
lib/ui/components/cv_skimmer.dart
Outdated
| @@ -0,0 +1,227 @@ | |||
| import 'package:flutter/material.dart'; | |||
There was a problem hiding this comment.
Typo "Skimmer" -> "Shimmer" wherever used
|
Fixed typos please have a look |
| @@ -41,6 +43,40 @@ class _FeaturedProjectsViewState extends State<FeaturedProjectsView> { | |||
| ), | |||
| ); | |||
| }); | |||
| } else if (model.isBusy(model.FETCH_FEATURED_PROJECTS)) { | |||
| _items.add(Padding( | |||
There was a problem hiding this comment.
We can reduce code by making a single widget and adding it to the list 3 times.
|
okk i will do that |
|
ui test are failing in user_projects_view.dart logs 00:50 +226 -1: /home/saurabh/Desktop/circutverseapp/mobile-app/test/ui_tests/profile/profile_view_test.dart: ProfileViewTest - finds Generic MyGroupsView widgets [E] 00:51 +226 -1: /home/saurabh/Desktop/circutverseapp/mobile-app/test/ui_tests/authentication/signup_view_test.dart: SignupViewTest - When name/email/password is not valid or empty, proper error message should be shown |
|
In the logs I can see only ProfileViewTest failing and without exception logs. Can you send the full logs ? and also push the changes which are causing this, so that I can check. |
|
What exactly is the utility of using the exact same code from https://pub.dev/packages/shimmer rather than to just increase the number lines? @iCoder-007 Also, it's better to discuss this in #ux channel because if this gets approved, it should be used in place of all the loading indicators. |
@iCoder-007 |
|
Where is ux channel |
Check Slack Channel |
@iCoder-007 can you use |
|
Also you can't simply copy paste code from another open source library as it will be a copyright violation. For instance shimmer library is licensed under BSD, so copying code to our code base requires copyright notice from the original code |
|
okk i will replace it shimmer package |
|
Since the PR is now stale and due to new changes, I am closing this PR. Feel free to open another one anytime :) |
Screenshot :