Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/move everything from category continuation #540

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

juntereiner
Copy link
Contributor

@juntereiner juntereiner commented Aug 4, 2024

This is the continuation of #329. Original author is @fiote.

Related to #319 and #118 .

Copy link
Owner

@Cidan Cidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except two small things. See below and thank you!

frames/section.lua Outdated Show resolved Hide resolved
core/init.lua Outdated Show resolved Hide resolved
---@class Database: AceModule
local db = addon:GetModule('Database')

---@class movementFlow: AceModule
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module classes start with an upper case.

---@class Constants: AceModule
local const = addon:GetModule('Constants')

---@class movementFlow: AceModule
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module classes start with upper case. Note, this is for the class name, not the variable.

@Cidan Cidan merged commit 35ab769 into Cidan:main Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants