-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make clvm_rs
a replacement for clvm
#253
Draft
richardkiss
wants to merge
46
commits into
main
Choose a base branch
from
remove-clvm-dep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardkiss
commented
Feb 7, 2023
wheel/python/clvm_rs/bytes32.py
Outdated
@@ -0,0 +1 @@ | |||
bytes32 = bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to figure out what to do about this.
Quexington
reviewed
Feb 9, 2023
'This PR has been flagged as stale due to no activity for over 60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draws a lot of ideas from various places. Here are the key points:
CLVMStorage
protocol is fundamental. It has two attributes:atom
and the propertypair
, which is an implicit method callProgram
is the high level wrapper around the low level protocolCLVMStorage
. All API is hereProgram
andEvalError
(from clvm_rs import Program, EvalError
). Users shouldn't need any othersrun
is only supported via rust, and returns aLazyNode
which conforms toCLVMStorage
(and is generally wrapped byProgram
)sha256tree
values are cached when possible all through the treeSerializedProgram
is no longer needed asCLVMTree
replaces itCLVMTree
is great. Here's why:sha256tree
values (optionally, but by default) on parse, for the whole treeMOD
templates, as curry will be fast, hashing will be fast, and deserialization will be fastProgram